Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: yarn to bun #4083

Merged
merged 20 commits into from
Feb 28, 2025
Merged

build: yarn to bun #4083

merged 20 commits into from
Feb 28, 2025

Conversation

mastercactapus
Copy link
Member

@mastercactapus mastercactapus commented Sep 24, 2024

Description:
This PR switches from using yarn and Node.js to using bun for all package management and JavaScript execution when building/testing UI code. With corepack potentially going away and various historical issues with versions of Node.js causing build breakage, this PR will use the gettool devtool to pull in the proper version of bun in the same way we do for tools like sqlc.

This eliminates the project's dependency on having the correct version of Node.js and simplifies the build process. Many of the workarounds for yarn pnp can all be cleaned up as bun uses the standard node_modules, but with speed and efficiency similar to (and faster than, in some cases) yarn pnp. This speed was the primary reason we switched to yarn, so this change seemingly solves the whole set of problems we've faced in the past.

This PR does not replace the use of esbuild, although bun may be able to replace that functionality too in the future. For now, that piece is out of scope.

Which issue(s) this PR fixes:
No associated issue.

Out of Scope:
The replacement of esbuild functionality is out of scope for this PR.

Additional Info:

@mastercactapus mastercactapus marked this pull request as ready for review February 28, 2025 18:26
KatieMSB
KatieMSB previously approved these changes Feb 28, 2025
KatieMSB
KatieMSB previously approved these changes Feb 28, 2025
@mastercactapus mastercactapus merged commit e35d78f into master Feb 28, 2025
8 checks passed
@mastercactapus mastercactapus deleted the yarn-to-bun branch February 28, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants