Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql: destinations: add dest as a field on OnCallNotificationRule #3659

Merged
merged 4 commits into from
Feb 7, 2024

Conversation

mastercactapus
Copy link
Member

Description:
This PR updates the graphql API to allow returning display information for schedule notifications

Which issue(s) this PR fixes:
part of #2639

Describe any introduced API changes:

  • added dest as a field on OnCallNotificationRule
  • added missing experimental flag decorators to destinationFieldSearch and destinationFieldValueName
  • removed unused typeInfo field from Destination type
  • renamed unused display field from Destination type to displayInfo and implemented it's resolver

@github-actions github-actions bot added the size/m label Feb 7, 2024
tony-tvu
tony-tvu previously approved these changes Feb 7, 2024
ethan-haynes
ethan-haynes previously approved these changes Feb 7, 2024
allending313
allending313 previously approved these changes Feb 7, 2024
@mastercactapus mastercactapus merged commit d839c36 into master Feb 7, 2024
7 checks passed
@mastercactapus mastercactapus deleted the sched-on-call-dest-api branch February 7, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants