Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

destinations: update schedule notification list to use destinations #3656

Merged
merged 22 commits into from
Feb 8, 2024

Conversation

mastercactapus
Copy link
Member

@mastercactapus mastercactapus commented Feb 6, 2024

Description:
This PR updates the schedule on-call notification list to use destinations when the experimental flag is set

Which issue(s) this PR fixes:
part of #2639

Out of Scope:

  • create/edit/form functionality will be done separately

Describe any introduced user-facing changes:
N/A, behavior should be the same as today, with the exception of Slack now using the team/workspace icon instead of the generic slack icon.

Describe any introduced API changes:

  • added dest as a field on OnCallNotificationRule
  • added missing experimental flag decorators to destinationFieldSearch and destinationFieldValueName
  • removed unused typeInfo field from Destination type
  • renamed unused display field from Destination type to displayInfo and implemented it's resolver

Screenshots:

image

Additional Info:

  • Moved destination icon rendering to a new DestinationAvatar component so it can be used on chips as well as FlatList

@mastercactapus mastercactapus marked this pull request as ready for review February 6, 2024 20:31
@github-actions github-actions bot added the size/l label Feb 6, 2024
@github-actions github-actions bot added size/xl and removed size/l labels Feb 6, 2024
@mastercactapus mastercactapus marked this pull request as draft February 7, 2024 16:18
@mastercactapus mastercactapus marked this pull request as ready for review February 7, 2024 21:47
@github-actions github-actions bot removed the size/xl label Feb 7, 2024
@github-actions github-actions bot added the size/l label Feb 7, 2024
@mastercactapus mastercactapus merged commit 3af1cb2 into master Feb 8, 2024
9 checks passed
@mastercactapus mastercactapus deleted the sched-notif-dest branch February 8, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants