-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
destinations: update schedule notification list to use destinations #3656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web/src/app/schedules/on-call-notifications/ScheduleOnCallNotificationsListDest.stories.tsx
Outdated
Show resolved
Hide resolved
web/src/app/schedules/on-call-notifications/ScheduleOnCallNotificationsListDest.stories.tsx
Outdated
Show resolved
Hide resolved
tony-tvu
approved these changes
Feb 7, 2024
allending313
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates the schedule on-call notification list to use destinations when the experimental flag is set
Which issue(s) this PR fixes:
part of #2639
Out of Scope:
Describe any introduced user-facing changes:
N/A, behavior should be the same as today, with the exception of Slack now using the team/workspace icon instead of the generic slack icon.
Describe any introduced API changes:
dest
as a field onOnCallNotificationRule
destinationFieldSearch
anddestinationFieldValueName
typeInfo
field fromDestination
typedisplay
field fromDestination
type todisplayInfo
and implemented it's resolverScreenshots:
Additional Info:
DestinationAvatar
component so it can be used on chips as well asFlatList