New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: upgrade node version #3645

Merged

mastercactapus merged 10 commits into master from upgrade-node-in-ci

Feb 5, 2024

Collaborator

KatieMSB commented Feb 1, 2024

Upgrade node to version 20.11.0 in ci.


          update node

67ad8ef

github-actions bot added the size/xs label

Forfold previously approved these changes

View reviewed changes


          regen yarn.lock

fe0b29d

KatieMSB dismissed Forfold’s stale review via

fe0b29d

February 2, 2024 15:47

Forfold previously approved these changes

View reviewed changes


          update playwright version

bc1bdfb

KatieMSB dismissed Forfold’s stale review via

bc1bdfb

February 5, 2024 15:03

mastercactapus previously approved these changes

View reviewed changes


          run full install command

dcc0bf1

mastercactapus dismissed their stale review via

dcc0bf1

February 5, 2024 16:24


          install before component tests

89d7f26

mastercactapus previously approved these changes

View reviewed changes


          default install cmd

e9acd53

mastercactapus dismissed their stale review via

e9acd53

February 5, 2024 22:03

mastercactapus previously approved these changes

View reviewed changes

mastercactapus added 2 commits

February 5, 2024 16:12


          Revert "default install cmd"

9b95371

This reverts commit e9acd53.


          update yarnrc version

86aa543

mastercactapus dismissed their stale review via

86aa543

February 5, 2024 22:30

mastercactapus previously approved these changes

View reviewed changes


          ensure single version of playwright

b917579

mastercactapus dismissed their stale review via

b917579

February 5, 2024 22:35

mastercactapus previously approved these changes

View reviewed changes


          add check for multiple playwright versions

22fd2f9

mastercactapus dismissed their stale review via

22fd2f9

February 5, 2024 22:51

github-actions bot added size/s and removed size/xs labels

mastercactapus approved these changes

View reviewed changes

Member

mastercactapus commented Feb 5, 2024

Context on fixes:

Needed to add a yarn playwright install line to the test-components make target
Needed to ensure a single version of the playwright package is installed

We added to the codecheck.sh script to emit an error if multiple show up in yarn.lock since that was the source of a lot of time debugging.

ethan-haynes approved these changes

View reviewed changes

mastercactapus merged commit b508ace into master

7 checks passed

mastercactapus deleted the upgrade-node-in-ci branch

February 5, 2024 23:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels