Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/admin: prod build validation #3629

Merged
merged 12 commits into from
Jan 29, 2024
Merged

dev/admin: prod build validation #3629

merged 12 commits into from
Jan 29, 2024

Conversation

mastercactapus
Copy link
Member

Description:
This PR adds validation of the UI assets when running without the --ui-dir flag. A number of bugs/issues with development targets were also fixed.

  • All files under web/src (other than build/ and cypress/) will now trigger app.js to be rebuilt
  • Fixed dependency issues where yarn commands would never result in a stable state (always rebuild)
  • removed esbuild watcher from Procfiles that already use BUNDLE=1 (they would clobber each other)
  • app.js must now exist and the embedded GOALERT_VERSION MUST match the backend version (if --ui-dir is unset)
  • esbuild will now abort immediately if GOALERT_VERSION is undefined
  • Changing the GIT_VERSION (e.g., by making a commit) will now trigger a rebuild to keep version strings in sync

Additionally, make start-prod is much more efficient now and doesn't print endless noise in the console.

KatieMSB
KatieMSB previously approved these changes Jan 25, 2024
@mastercactapus mastercactapus merged commit 0700a96 into master Jan 29, 2024
7 checks passed
@mastercactapus mastercactapus deleted the prod-build-validation branch January 29, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants