Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds validation of the UI assets when running without the
--ui-dir
flag. A number of bugs/issues with development targets were also fixed.web/src
(other thanbuild/
andcypress/
) will now triggerapp.js
to be rebuiltBUNDLE=1
(they would clobber each other)app.js
must now exist and the embeddedGOALERT_VERSION
MUST match the backend version (if--ui-dir
is unset)GOALERT_VERSION
is undefinedGIT_VERSION
(e.g., by making a commit) will now trigger a rebuild to keep version strings in syncAdditionally,
make start-prod
is much more efficient now and doesn't print endless noise in the console.