Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui/service: convert ServiceOnCallList to typescript #3512

Merged
merged 2 commits into from
Dec 11, 2023
Merged

ui/service: convert ServiceOnCallList to typescript #3512

merged 2 commits into from
Dec 11, 2023

Conversation

KatieMSB
Copy link
Collaborator

@KatieMSB KatieMSB commented Dec 5, 2023

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Converts to use typescript and migrates from @apollo/client to urql.

Which issue(s) this PR fixes:
Part of #3240 and #2318
Closes #3308

@github-actions github-actions bot added the size/s label Dec 5, 2023
@Forfold Forfold merged commit c9fa58f into master Dec 11, 2023
@Forfold Forfold deleted the service-oncall-list-typescript branch December 11, 2023 19:09
@Forfold Forfold mentioned this pull request Jan 9, 2024
Open
76 tasks
@KatieMSB KatieMSB mentioned this pull request Feb 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastercactapus mastercactapus mastercactapus approved these changes

@Forfold Forfold Forfold approved these changes

Assignees
No one assigned
Labels
size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect on-call user count on service page
3 participants
@KatieMSB @mastercactapus @Forfold