Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui/rotations: convert RotationAddUserDialog file to ts #2433

Merged
merged 4 commits into from
Jun 17, 2022
Merged

ui/rotations: convert RotationAddUserDialog file to ts #2433

merged 4 commits into from
Jun 17, 2022

Conversation

tony-tvu
Copy link
Collaborator

@tony-tvu tony-tvu commented Jun 7, 2022

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Part of an ongoing effort to convert existing javascript files to typescript.

Which issue(s) this PR fixes:
#2318

@tony-tvu tony-tvu merged commit 800bfc8 into master Jun 17, 2022
@tony-tvu tony-tvu deleted the ts-conversion-RotationAddUserDialog branch June 17, 2022 20:14
@nataliekorzh nataliekorzh mentioned this pull request Nov 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Forfold Forfold Forfold approved these changes

@KatieMSB KatieMSB KatieMSB approved these changes

Assignees
No one assigned
Labels
ts-conversion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tony-tvu @Forfold @KatieMSB