Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui/error-pages: convert Error files to typescript #2367

Merged
merged 3 commits into from
May 11, 2022
Merged

ui/error-pages: convert Error files to typescript #2367

merged 3 commits into from
May 11, 2022

Conversation

tony-tvu
Copy link
Collaborator

@tony-tvu tony-tvu commented May 5, 2022

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Part of an ongoing effort to convert existing javascript files to typescript.

Which issue(s) this PR fixes:
#2318

@tony-tvu tony-tvu mentioned this pull request May 5, 2022
Open
mastercactapus
mastercactapus requested changes May 10, 2022
View reviewed changes
Copy link
Member

@mastercactapus mastercactapus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When switching to typescript types, we can remove the propTypes too

@tony-tvu tony-tvu requested a review from mastercactapus May 10, 2022 19:10
KatieMSB
KatieMSB approved these changes May 10, 2022
View reviewed changes
Copy link
Collaborator

@KatieMSB KatieMSB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏽

@tony-tvu tony-tvu merged commit dae55df into master May 11, 2022
@tony-tvu tony-tvu deleted the use-typescript-Errors branch May 11, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastercactapus mastercactapus mastercactapus approved these changes

@KatieMSB KatieMSB KatieMSB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tony-tvu @mastercactapus @KatieMSB