You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In a PR (#2434) converting a Dialog component to Typescript rendered as a child of SimpleListPage component was forced to set the onClose prop to optional, because in SimpleListPage we clone the passed Dialog component and then append the onClose property to props.
We should think about setting onClose to required for our Dialog components, which would require SimpleListPage to accept a Component instead of a JSX.Element.
In a PR (#2434) converting a Dialog component to Typescript rendered as a child of
SimpleListPage
component was forced to set theonClose
prop to optional, because inSimpleListPage
we clone the passed Dialog component and then append the onClose property to props.We should think about setting
onClose
to required for our Dialog components, which would requireSimpleListPage
to accept a Component instead of a JSX.Element.E.g.
would change to
and we could add a render prop option, too, if some components need to pull off some shenanigans in scope as well:
The text was updated successfully, but these errors were encountered: