Merge pull request #2434 from target/ts-conversion-RotationCreateDialog

ui/rotations: convert RotationCreateDialog to ts
target · Jun 17, 2022 · a2c2cbd · a2c2cbd
2 parents 1dea0b0 + 548c5ed
commit a2c2cbd
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 16 deletions.
diff --git a/...src/app/rotations/RotationCreateDialog.js → ...rc/app/rotations/RotationCreateDialog.tsx b/...src/app/rotations/RotationCreateDialog.js → ...rc/app/rotations/RotationCreateDialog.tsx
@@ -1,12 +1,21 @@
 import React, { useState } from 'react'
 import { gql, useMutation } from '@apollo/client'
-import p from 'prop-types'
 import { nonFieldErrors, fieldErrors } from '../util/errutil'
 import FormDialog from '../dialogs/FormDialog'
 import RotationForm from './RotationForm'
 import { DateTime } from 'luxon'
 import { Redirect } from 'wouter'
 
+interface Value {
+  name: string
+  description: string
+  timeZone: string
+  type: string
+  start: string
+  shiftLength: number
+  favorite: boolean
+}
+
 const mutation = gql`
   mutation ($input: CreateRotationInput!) {
     createRotation(input: $input) {
@@ -20,18 +29,17 @@ const mutation = gql`
     }
   }
 `
-const initialValue = {
-  name: '',
-  description: '',
-  timeZone: Intl.DateTimeFormat().resolvedOptions().timeZone,
-  type: 'daily',
-  start: DateTime.local().plus({ hours: 1 }).startOf('hour').toISO(),
-  shiftLength: 1,
-  favorite: true,
-}
 
-const RotationCreateDialog = (props) => {
-  const [value, setValue] = useState(initialValue)
+const RotationCreateDialog = (props: { onClose?: () => void }): JSX.Element => {
+  const [value, setValue] = useState<Value>({
+    name: '',
+    description: '',
+    timeZone: Intl.DateTimeFormat().resolvedOptions().timeZone,
+    type: 'daily',
+    start: DateTime.local().plus({ hours: 1 }).startOf('hour').toISO(),
+    shiftLength: 1,
+    favorite: true,
+  })
   const [createRotationMutation, { loading, data, error }] = useMutation(
     mutation,
     {
@@ -66,8 +74,4 @@ const RotationCreateDialog = (props) => {
   )
 }
 
-RotationCreateDialog.propTypes = {
-  onClose: p.func,
-}
-
 export default RotationCreateDialog
diff --git a/web/src/app/rotations/RotationForm.js b/web/src/app/rotations/RotationForm.js
@@ -236,4 +236,5 @@ RotationForm.propTypes = {
   ),
 
   onChange: p.func.isRequired,
+  disabled: p.bool,
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -236,4 +236,5 @@ RotationForm.propTypes = { @@
       ),
       onChange: p.func.isRequired,
+      disabled: p.bool,
     }