[PH2][Test][Transport] Refactor Chaotic Good Tests (grpc#38791)

[PH2][Test][Transport] Refactor Chaotic Good Tests

Moving the tests to a common util folder where they can be used by both Chaotic Good and HTTP2 Transport.

Closes grpc#38791

COPYBARA_INTEGRATE_REVIEW=grpc#38791 from tanvi-jagtap:move_common_test_file_to_util b8e5704
PiperOrigin-RevId: 729325544

test/core/transport/chaotic_good/BUILD

@@ -23,10 +23,10 @@ grpc_package(
 )
 
 grpc_cc_library(
-    name = "transport_test",
+    name = "transport_test_helper",
     testonly = 1,
-    srcs = ["transport_test.cc"],
-    hdrs = ["transport_test.h"],
+    srcs = ["transport_test_helper.cc"],
+    hdrs = ["transport_test_helper.h"],
     external_deps = ["gtest"],
     deps = [
         "//:iomgr_timer",
@@ -135,7 +135,7 @@ grpc_cc_test(
     uses_event_engine = False,
     uses_polling = False,
     deps = [
-        "transport_test",
+        "transport_test_helper",
         "//:grpc",
         "//:grpc_public_hdrs",
         "//src/core:arena",
@@ -145,6 +145,7 @@ grpc_cc_test(
         "//src/core:seq",
         "//src/core:slice_buffer",
         "//test/core/transport/util:mock_promise_endpoint",
+        "//test/core/transport/util:transport_test",
     ],
 )
 
@@ -197,7 +198,7 @@ grpc_cc_test(
     uses_event_engine = False,
     uses_polling = False,
     deps = [
-        "transport_test",
+        "transport_test_helper",
         "//:grpc",
         "//:grpc_public_hdrs",
         "//:iomgr_timer",
@@ -212,6 +213,7 @@ grpc_cc_test(
         "//test/core/event_engine/fuzzing_event_engine",
         "//test/core/event_engine/fuzzing_event_engine:fuzzing_event_engine_cc_proto",
         "//test/core/transport/util:mock_promise_endpoint",
+        "//test/core/transport/util:transport_test",
     ],
 )
 

test/core/transport/chaotic_good/client_transport_test.cc

@@ -38,14 +38,16 @@
 #include "gtest/gtest.h"
 #include "src/core/config/core_configuration.h"
 #include "src/core/ext/transport/chaotic_good/chaotic_good_frame.pb.h"
+#include "src/core/ext/transport/chaotic_good/frame.h"
 #include "src/core/lib/promise/if.h"
 #include "src/core/lib/promise/loop.h"
 #include "src/core/lib/promise/seq.h"
 #include "src/core/lib/resource_quota/arena.h"
 #include "src/core/lib/slice/slice_buffer.h"
 #include "src/core/lib/transport/metadata_batch.h"
-#include "test/core/transport/chaotic_good/transport_test.h"
+#include "test/core/transport/chaotic_good/transport_test_helper.h"
 #include "test/core/transport/util/mock_promise_endpoint.h"
+#include "test/core/transport/util/transport_test.h"
 
 using testing::MockFunction;
 using testing::Return;

test/core/transport/chaotic_good/server_transport_test.cc

@@ -45,8 +45,9 @@
 #include "src/core/util/ref_counted_ptr.h"
 #include "test/core/event_engine/fuzzing_event_engine/fuzzing_event_engine.h"
 #include "test/core/event_engine/fuzzing_event_engine/fuzzing_event_engine.pb.h"
-#include "test/core/transport/chaotic_good/transport_test.h"
+#include "test/core/transport/chaotic_good/transport_test_helper.h"
 #include "test/core/transport/util/mock_promise_endpoint.h"
+#include "test/core/transport/util/transport_test.h"
 
 using testing::_;
 using testing::MockFunction;

test/core/transport/chaotic_good/transport_test.cc → test/core/transport/chaotic_good/transport_test_helper.cc

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#include "test/core/transport/chaotic_good/transport_test.h"
+#include "test/core/transport/chaotic_good/transport_test_helper.h"
 
 namespace grpc_core {
 namespace chaotic_good {

test/core/transport/chaotic_good/transport_test_helper.h

@@ -0,0 +1,55 @@
+// Copyright 2023 gRPC authors.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#ifndef GRPC_TEST_CORE_TRANSPORT_CHAOTIC_GOOD_TRANSPORT_TEST_HELPER_H
+#define GRPC_TEST_CORE_TRANSPORT_CHAOTIC_GOOD_TRANSPORT_TEST_HELPER_H
+
+#include <google/protobuf/text_format.h>
+
+#include "gmock/gmock.h"
+#include "gtest/gtest.h"
+#include "src/core/ext/transport/chaotic_good/frame.h"
+#include "src/core/lib/event_engine/event_engine_context.h"
+#include "src/core/lib/iomgr/timer_manager.h"
+#include "src/core/lib/resource_quota/memory_quota.h"
+#include "src/core/lib/resource_quota/resource_quota.h"
+#include "src/core/lib/transport/call_arena_allocator.h"
+#include "src/core/lib/transport/call_spine.h"
+#include "test/core/event_engine/fuzzing_event_engine/fuzzing_event_engine.h"
+#include "test/core/event_engine/fuzzing_event_engine/fuzzing_event_engine.pb.h"
+
+namespace grpc_core {
+namespace chaotic_good {
+namespace testing {
+
+grpc_event_engine::experimental::Slice SerializedFrameHeader(
+    FrameType type, uint16_t payload_connection_id, uint32_t stream_id,
+    uint32_t payload_length);
+
+grpc_event_engine::experimental::Slice Zeros(uint32_t length);
+
+template <typename T>
+grpc_event_engine::experimental::Slice EncodeProto(const std::string& fields) {
+  T msg;
+  CHECK(google::protobuf::TextFormat::ParseFromString(fields, &msg));
+  std::string out;
+  CHECK(msg.SerializeToString(&out));
+  return grpc_event_engine::experimental::Slice::FromCopiedString(out);
+}
+
+}  // namespace testing
+}  // namespace chaotic_good
+}  // namespace grpc_core
+
+#endif  // GRPC_TEST_CORE_TRANSPORT_CHAOTIC_GOOD_TRANSPORT_TEST_HELPER_H

test/core/transport/util/BUILD

@@ -32,3 +32,17 @@ grpc_cc_library(
         "//src/core:grpc_promise_endpoint",
     ],
 )
+
+grpc_cc_library(
+    name = "transport_test",
+    testonly = 1,
+    hdrs = ["transport_test.h"],
+    external_deps = ["gtest"],
+    deps = [
+        "//:iomgr_timer",
+        "//src/core:memory_quota",
+        "//src/core:resource_quota",
+        "//test/core/event_engine/fuzzing_event_engine",
+        "//test/core/event_engine/fuzzing_event_engine:fuzzing_event_engine_cc_proto",
+    ],
+)

test/core/transport/chaotic_good/transport_test.h → test/core/transport/util/transport_test.h

@@ -12,14 +12,13 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#ifndef GRPC_TEST_CORE_TRANSPORT_CHAOTIC_GOOD_TRANSPORT_TEST_H
-#define GRPC_TEST_CORE_TRANSPORT_CHAOTIC_GOOD_TRANSPORT_TEST_H
+#ifndef GRPC_TEST_CORE_TRANSPORT_UTIL_TRANSPORT_TEST_H
+#define GRPC_TEST_CORE_TRANSPORT_UTIL_TRANSPORT_TEST_H
 
 #include <google/protobuf/text_format.h>
 
 #include "gmock/gmock.h"
 #include "gtest/gtest.h"
-#include "src/core/ext/transport/chaotic_good/frame.h"
 #include "src/core/lib/event_engine/event_engine_context.h"
 #include "src/core/lib/iomgr/timer_manager.h"
 #include "src/core/lib/resource_quota/memory_quota.h"
@@ -74,23 +73,8 @@ class TransportTest : public ::testing::Test {
           1024)};
 };
 
-grpc_event_engine::experimental::Slice SerializedFrameHeader(
-    FrameType type, uint16_t payload_connection_id, uint32_t stream_id,
-    uint32_t payload_length);
-
-grpc_event_engine::experimental::Slice Zeros(uint32_t length);
-
-template <typename T>
-grpc_event_engine::experimental::Slice EncodeProto(const std::string& fields) {
-  T msg;
-  CHECK(google::protobuf::TextFormat::ParseFromString(fields, &msg));
-  std::string out;
-  CHECK(msg.SerializeToString(&out));
-  return grpc_event_engine::experimental::Slice::FromCopiedString(out);
-}
-
 }  // namespace testing
 }  // namespace chaotic_good
 }  // namespace grpc_core
 
-#endif  // GRPC_TEST_CORE_TRANSPORT_CHAOTIC_GOOD_TRANSPORT_TEST_H
+#endif  // GRPC_TEST_CORE_TRANSPORT_UTIL_TRANSPORT_TEST_H