Add ruby op-or-equals command #1347
Conversation
- without this, saying `op or equals` would be interpreted as `op or` followed by `equals`, which results in a syntax error `|| =`
|
IMO we should implement this for other languages too. For example JavaScript implements logical and/or assignment as well it can probably go in https://github.com/talonhub/community/blob/main/lang/tags/operators_assignment.talon with the rest of them |
|
I'm not confident that every language that inherits that file supports it; and, I'm not sure how to do it for every language. My preference would be to keep this small and targeted to what I know and then refactor after it has been implemented everywhere. I only care about Ruby today because using this operator is idiomatic in Ruby. Can we live with this approach for now? |
We don't implement every one of those actions in that file for every language that asserts that tag anyway |
|
Ah, ok. I'm fine with adding it to JavaScript as well then. I'll add that when I can, or please feel free to edit this or submit a new PR with the change if you get to it first. |
- Defines generic method that can apply to various languages
|
I updated this based on your feedback. Thanks! |
* 'main' of github.com:talonhub/community: (73 commits) add lowercased firefox-esr to firefox.py (talonhub#1410) configurable number prefix without mouse grid (talonhub#1342) Update app.exe matching to work with both public and beta Talon (talonhub#1385) Add comment line to javascript (talonhub#1387) Add detail to documentation (talonhub#1380) Switch to black pre-commit mirror (talonhub#1378) Update app_name_overrides.windows.csv to use Windows Terminal instead of iTerm2 (talonhub#1379) [pre-commit.ci] pre-commit autoupdate (talonhub#1376) coalesce some list updates (talonhub#1348) Remove unused setting from c code language (talonhub#1368) mouse: adding synonyms for starting left drag. (talonhub#1356) Adds commands to focus on the last application (talonhub#1336) Stop using “brackets” to mean “braces” (talonhub#1344) Update settings descriptions (talonhub#1371) Revert changes to `user.mouse_enable_pop_click` (talonhub#1370) Fix typo in `mouse.py` variable name (talonhub#1372) Convert boolean settings to boolean (talonhub#1360) Add ruby op-or-equals command (talonhub#1347) added app name Mate-terminal (fork of Gnome-terminal) (talonhub#1367) added app name Caja (fork of Nautilus) (talonhub#1366) ...
- without this, saying `op or equals` would be interpreted as `op or` followed by `equals`, which results in a syntax error `|| =`
op or equalswould be interpreted asop orfollowed by
equals, which results in a syntax error|| =