Adds basic support for the Arc web browser #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jaresty
commented
Dec 7, 2023
•
jaresty
commented
- this is heavily borrowed from the Chrome support
- this is heavily burrowed from the Chrome support
david-tejada
reviewed
Dec 9, 2023
david-tejada
reviewed
Dec 9, 2023
- If you say please followed by some text it will search for that in the command palette - If you just say please it will only open the command palette
for more information, see https://pre-commit.ci
- for some reason it does not input the text into the little arc window - this makes it unusable
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
I added a comment. By the way, I don't have write access so my review won't be enough for the "review required" criteria. But don't worry, someone will review it and merge it when they have time. |
- this should ensure that arc has time to respond
for more information, see https://pre-commit.ci
- adds a comment to clarify that requirement
fidgetingbits
approved these changes
Dec 16, 2023
auscompgeek
requested changes
Dec 16, 2023
- these are mac specific
|
Sure thing. I don't have a windows box to test so I'll rename them. |
auscompgeek
requested changes
Dec 16, 2023
- properly restrict talonscript files to mac
|
I think this one is ok to merge now. The additional changes to mac only lgtm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.