Add Alchemy endpoint for Arbitrum Sepolia #3665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Moving to draft until Alchemy issues will be resolved |
|
Actually tested again and it is now working as expected. Ready for review. |
ioay
approved these changes
Nov 17, 2023
|
Please update the branch with the main and check playwright tests, because there's a timeout issue. |
Merged
Shadowfiend
added a commit
that referenced
this pull request
Nov 23, 2023
## What's Changed * Check connecting to dapp on different network after disconnecting by @michalinacienciala in #3654 * v0.51.0 by @Shadowfiend in #3652 * Fix typos by @xiaolou86 in #3668 * Alchemic Logs: Small improvements for eth_getLogs by @Shadowfiend in #3664 * Fix getting currently connected dapp info by @jagodarybacka in #3671 * Add static subcape link to the wallet by @jagodarybacka in #3670 * Fix e2e tests by @michalinacienciala in #3651 * Add Alchemy endpoint for Arbitrum Sepolia by @jagodarybacka in #3665 * Do notify: Set up base NotificationService by @Shadowfiend in #3666 ## New Contributors * @xiaolou86 made their first contribution in #3668 **Full Changelog**: v0.51.0...v0.52.0 Latest build: [extension-builds-3678](https://github.com/tahowallet/extension/suites/18415208655/artifacts/1067210815) (as of Wed, 22 Nov 2023 14:53:11 GMT).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
As Alchemy started to support Arbitrum Sepolia we can switch the wallet to use Alchemy endpoint by default.
Issues:
externalflag foralchemy_getAssetTransferson Arb Sepolia, it is responding with server error that these are not supported on a given chain despite docs claiming otherwisealchemy_getTokenBalancesis failing often with server error (timeout) - seems like it is a problem on Alchemy sideThese are not totally blocking because most of the time requests are working fine and we have backup providers as well but I would rather talk to Alchemy support about these problems first, before merging this PR.
Testing steps
Latest build: extension-builds-3665 (as of Mon, 20 Nov 2023 16:33:19 GMT).