Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ubuntu & windows & macos CI #96

Merged
merged 8 commits into from
Nov 29, 2023
Merged

Conversation

Gusarich
Copy link
Member

I've only made it to build and run tests. Do you think we need anything else to run there @anton-trunov ?

also it fails on windows by default... I cannot check it myself right now (I'm on macos), but looks like something's wrong with paths

@Gusarich Gusarich mentioned this pull request Nov 28, 2023
@anton-trunov anton-trunov linked an issue Nov 28, 2023 that may be closed by this pull request
@anton-trunov
Copy link
Member

Do you think we need anything else to run there @anton-trunov ?

I think running tact-template's tests with the most recent version of Tact on each PR would be beneficial. And when we fix the dependencies for Blueprint and Tact to work together, having Blueprint-based tests would be awesome.

@anton-trunov
Copy link
Member

also it fails on windows by default

I'll try to look at it, although I don't have access to Windows as well

@anton-trunov
Copy link
Member

Looks like I've fixed the Windows CI failures. I'd probably merge this as is if you think it's ready

@Gusarich
Copy link
Member Author

Looks like I've fixed the Windows CI failures. I'd probably merge this as is if you think it's ready

It builds successfully now:

let’s merge it! I’ll add tact-template testing in a separate PR

@anton-trunov anton-trunov merged commit 53d68b3 into tact-lang:main Nov 29, 2023
@anton-trunov
Copy link
Member

Thanks for your PR <3

I’ll add tact-template testing in a separate PR

That would be awesome! I created a separate issue for this: #98

hitaspdotnet pushed a commit to hitaspdotnet/tact that referenced this pull request Dec 9, 2023
Also fixes the build and tests on Windows

Co-authored-by: Anton Trunov <anton@ton.com>
@anton-trunov anton-trunov added the scope: ci Continuous Integration: GitHub Actions (.github), commit/push hooks (.husky) label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: ci Continuous Integration: GitHub Actions (.github), commit/push hooks (.husky)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI to the repo
2 participants