Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add .del function to maps #95

Merged
merged 6 commits into from
Apr 25, 2024
Merged

add .del function to maps #95

merged 6 commits into from
Apr 25, 2024

Conversation

Gusarich
Copy link
Member

very simple update, but for some reason I cannot proceed with making it to work.

The strangest thing is that by commenting different Del receivers in the maps.tact file I'm getting different results during compilation:

  • leaving all DelAddrMap receivers: successful compilation
  • leaving all DelAddrMap's and one DelIntMap1:
💼 Compiling project maps...
  > MapTestContract: tact compiler
  > MapTestContract: func compiler
[ 1][t 0][2023-11-28 17:35:35.101000][Fift.cpp:67]      top: <continuation 0x28e3a50>
level 1: <continuation 0x28e3ad0>
level 2: <text interpreter continuation>

main.fif:6134:  s(:-?
💥 Compilation failed. Skipping packaging
  • leaving all DelAddrMap's, DelIntMap1 and DelIntMap2:
💼 Compiling project maps...
   > MapTestContract: tact compiler
   > MapTestContract: func compiler
File not found
💥 Compilation failed. Skipping packaging

I've been unsuccessfully trying to solve the problem for few hours already..

@anton-trunov anton-trunov added the kind: language feature Intent to add a language feature label Nov 30, 2023
@anton-trunov anton-trunov added this to the v1.2.0 milestone Nov 30, 2023
@anton-trunov anton-trunov linked an issue Nov 30, 2023 that may be closed by this pull request
Key deletion syntax for maps #101
Closed
@Gusarich Gusarich mentioned this pull request Dec 1, 2023
Closed
8 tasks
@anton-trunov anton-trunov modified the milestones: v1.2.0, v1.3.0 Feb 16, 2024
@anton-trunov anton-trunov self-assigned this Feb 16, 2024
@anton-trunov anton-trunov added the feature: maps The map datatype and operations on it label Mar 5, 2024
@Gusarich Gusarich force-pushed the dict_key_deletion branch from 1fac6c5 to 6c91c48 Compare April 22, 2024 10:56
@Gusarich Gusarich force-pushed the dict_key_deletion branch from 6c91c48 to e995413 Compare April 25, 2024 10:08
@Gusarich Gusarich marked this pull request as ready for review April 25, 2024 10:11
@Gusarich Gusarich requested a review from anton-trunov April 25, 2024 10:11
anton-trunov
anton-trunov requested changes Apr 25, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff! I think we should change del's type signature (see below) and add some negative type checker tests just to be on the safe side

src/abi/map.ts Outdated Show resolved Hide resolved
@anton-trunov anton-trunov merged commit 1ef4691 into tact-lang:main Apr 25, 2024
3 checks passed
@anton-trunov anton-trunov mentioned this pull request Apr 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

Assignees

@anton-trunov anton-trunov

Labels
feature: maps The map datatype and operations on it kind: language feature Intent to add a language feature
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Key deletion syntax for maps
2 participants
@Gusarich @anton-trunov