-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow underscores as unused variable identifiers #338
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's fix the merge conflicts here
As of now, it only works for |
Are there any other cases where we need it? |
I don't think so, at least now. When we'll have #298 in the future, identifiers in |
Actually,
When we have a bit of type inference, the snippet above will become
In this case a static analyzer won't complain about unused values, whereas it should issue a warning for
if |
c266a97
to
2794628
Compare
Added support for let-statements and also resolved all merge conflicts |
2794628
to
22005cd
Compare
resolved merge conflicts |
22005cd
to
a9002a6
Compare
@anton-trunov resolved merge conflicts yet again after merge of #198 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there!
@anton-trunov have a look |
Closes #319