Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: mention negative tests in PR template #309

Merged
merged 2 commits into from
Apr 28, 2024
Merged

chore: mention negative tests in PR template #309

merged 2 commits into from
Apr 28, 2024

Conversation

anton-trunov
Copy link
Member

Closes #308

  • I have updated CHANGELOG.md
  • I have added unit tests to demonstrate the contribution is correctly implemented
  • I have run all the tests locally and no test failure was reported
  • I did not do unrelated and/or undiscussed refactorings

@anton-trunov anton-trunov requested a review from novusnota April 28, 2024 09:59
@anton-trunov anton-trunov added this to the v1.3.0 milestone Apr 28, 2024
@anton-trunov @novusnota
Update .github/pull_request_template.md
1d235d6 
Co-authored-by: Novus Nota <68142933+novusnota@users.noreply.github.com>
novusnota
novusnota approved these changes Apr 28, 2024
View reviewed changes
Copy link
Member

@novusnota novusnota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anton-trunov anton-trunov merged commit 6aa2512 into main Apr 28, 2024
3 checks passed
@anton-trunov anton-trunov deleted the pr-template-negative-tests branch April 28, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novusnota novusnota novusnota approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Pull request template should mention negative tests
2 participants
@anton-trunov @novusnota