Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix large contracts compilation by updating FunC to 0.4.4 with a WASM-related patch #297

Merged
merged 7 commits into from
Apr 25, 2024

Conversation

anton-trunov
Copy link
Member

@anton-trunov anton-trunov commented Apr 25, 2024

Closes #171

  • I have updated CHANGELOG.md
  • I have added unit tests to demonstrate the contribution is correctly implemented
  • I have run all the tests locally and no test failure was reported
  • I did not do unrelated and/or undiscussed refactorings

bug

I have used ton-blockchain/ton@4cfe1d1
to patch and compile the new WASM version of FunC.
In the patched version, the first argument to `PSTRING()` [here](https://github.com/ton-blockchain/ton/blob/4cfe1d1a96acf956e28e2bbc696a143489e23631/crypto/fift/utils.cpp#L215-L216) is built as an `std::string` first.
Otherwise the wrapped `asm_code` gets truncated in WASM version.
looks like it wasn't updated in one the previous PRs
@anton-trunov anton-trunov added this to the v1.3.0 milestone Apr 25, 2024
@anton-trunov anton-trunov merged commit f777da3 into main Apr 25, 2024
3 checks passed
@anton-trunov anton-trunov deleted the fix-large-contracts-compilation branch April 25, 2024 10:01
@anton-trunov anton-trunov changed the title Fix large contracts compilation Fix large contracts compilation by updating FunC to 0.4.4 with a WASM-related patch Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two compile failed for a large single smart contract
2 participants