Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pow and pow2 to stdlib #267

Merged
merged 7 commits into from
Apr 21, 2024
Merged

Add pow and pow2 to stdlib #267

merged 7 commits into from
Apr 21, 2024

Conversation

Gusarich
Copy link
Member

@Gusarich Gusarich commented Apr 19, 2024 •
edited
Loading

Closes #264

  • I have updated CHANGELOG.md
  • I have added unit tests to demonstrate the contribution is correctly implemented
  • I have run all the tests locally and no test failure was reported
  • I did not do unrelated and/or undiscussed refactorings

@Gusarich Gusarich requested a review from anton-trunov April 19, 2024 09:57
@Gusarich Gusarich changed the title add pow and pow2 to stdlib && implement constant evaluation Add pow and pow2 to stdlib Apr 19, 2024
@anton-trunov anton-trunov self-assigned this Apr 19, 2024
@anton-trunov anton-trunov added this to the v1.3.0 milestone Apr 19, 2024
@Gusarich
Copy link
Member Author

I will resolve merge conflicts now

anton-trunov
anton-trunov requested changes Apr 19, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

way to go! left a few comments, though

src/test/feature-math.spec.ts Outdated Show resolved Hide resolved
src/generator/writers/writeStdlib.ts Show resolved Hide resolved
@Gusarich Gusarich requested a review from anton-trunov April 20, 2024 16:11
anton-trunov
anton-trunov approved these changes Apr 21, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anton-trunov anton-trunov merged commit 8410733 into tact-lang:main Apr 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Support exponentiation pow function at runtime
2 participants
@Gusarich @anton-trunov