Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bitwise xor operation #238

Merged
merged 7 commits into from
Apr 19, 2024
Merged

Add bitwise xor operation #238

merged 7 commits into from
Apr 19, 2024

Conversation

Gusarich
Copy link
Member

@Gusarich Gusarich commented Apr 10, 2024 •
edited by anton-trunov
Loading

Closes #119

  • I have updated CHANGELOG.md
  • I have added unit tests to demonstrate the contribution is correctly implemented
  • I have run all the tests locally and no test failure was reported
  • I did not do unrelated and/or undiscussed refactorings

@Gusarich Gusarich requested a review from anton-trunov April 10, 2024 10:23
@anton-trunov anton-trunov linked an issue Apr 11, 2024 that may be closed by this pull request
[feat] bitwise XOR not supported #119
Closed
anton-trunov
anton-trunov requested changes Apr 11, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

CHANGELOG.md Outdated Show resolved Hide resolved
src/types/resolveConstantValue.ts Show resolved Hide resolved
src/test/feature-math.spec.ts Show resolved Hide resolved
@anton-trunov anton-trunov self-assigned this Apr 11, 2024
@anton-trunov anton-trunov added this to the v1.3.0 milestone Apr 11, 2024
@Gusarich Gusarich requested a review from anton-trunov April 17, 2024 10:10
anton-trunov
anton-trunov requested changes Apr 17, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost ready for merging. We need to add tests for the new getters in contstants.tact and fix merge conflicts with the main branch

src/test/features/constants.tact Outdated Show resolved Hide resolved
@anton-trunov anton-trunov changed the title Add xor operation Add bitwise xor operation Apr 17, 2024
anton-trunov
anton-trunov requested changes Apr 17, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an operator precedence issue, see #263. Let's fix the issue first and then rebase this PR on top of the fix. A separate fix is needed to not mix new tests with the ones in this PR.

src/grammar/grammar.ohm Outdated Show resolved Hide resolved
@Gusarich Gusarich requested a review from anton-trunov April 19, 2024 09:18
anton-trunov
anton-trunov approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job!

@anton-trunov anton-trunov merged commit ab7c7aa into tact-lang:main Apr 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

[feat] bitwise XOR not supported
2 participants
@Gusarich @anton-trunov