Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constant evaluation of newAddress #237

Merged
merged 5 commits into from
Apr 17, 2024
Merged

Constant evaluation of newAddress #237

merged 5 commits into from
Apr 17, 2024

Conversation

Gusarich
Copy link
Member

@Gusarich Gusarich commented Apr 10, 2024 •
edited
Loading

Closes #214

  • I have updated CHANGELOG.md
  • I have added unit tests to demonstrate the contribution is correctly implemented
  • I have run all the tests locally and no test failure was reported
  • I did not do unrelated and/or undiscussed refactorings

also covered constants with test. for some reason there were no checks for their values.

@Gusarich Gusarich requested a review from anton-trunov April 10, 2024 10:00
@anton-trunov anton-trunov self-assigned this Apr 11, 2024
@anton-trunov anton-trunov added this to the v1.3.0 milestone Apr 11, 2024
anton-trunov
anton-trunov approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anton-trunov anton-trunov merged commit d73a836 into tact-lang:main Apr 17, 2024
3 checks passed
@Gusarich Gusarich mentioned this pull request Apr 17, 2024
Merged
4 tasks
@novusnota novusnota mentioned this pull request Jun 29, 2024
Closed
@verytactical verytactical added the scope: partial-eval The constant and partial evaluation optimization mechanisms (src/optimizer/constEval.ts) label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

Assignees

@anton-trunov anton-trunov

Labels
scope: partial-eval The constant and partial evaluation optimization mechanisms (src/optimizer/constEval.ts)
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

newAddress() should be const eval
3 participants
@Gusarich @anton-trunov @verytactical