Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Remove duplicates from ASTNode #204

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

byakuren-hijiri
Copy link
Contributor

Having duplicates in a union type does not affect the type's functionality, so we can safely remove them.

Gusarich
Gusarich previously approved these changes Mar 28, 2024
Copy link
Member

@Gusarich Gusarich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Adding this check requires specifying `parserOptions.project`,
which in its turn requires a custom tsconfig.json so ESLint
works correctly
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff! I added an ESLint check to prevent these kinds of issues appear in the future

@anton-trunov anton-trunov merged commit 06bcc56 into tact-lang:main Mar 28, 2024
3 checks passed
@anton-trunov
Copy link
Member

Hmm, looks like the PR template was not applied by GitHub here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants