From d4f4b6b6caaf70d23377e5fa93c70e61c891744e Mon Sep 17 00:00:00 2001 From: Anton Trunov Date: Wed, 27 Mar 2024 21:45:34 +0300 Subject: [PATCH 1/4] chore: add a pull request template --- .github/workflows/pull_request_template.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .github/workflows/pull_request_template.md diff --git a/.github/workflows/pull_request_template.md b/.github/workflows/pull_request_template.md new file mode 100644 index 000000000..4f01f568b --- /dev/null +++ b/.github/workflows/pull_request_template.md @@ -0,0 +1,6 @@ +Closes issue #number + +* [ ] I have updated CHANGELOG.md +* [ ] I have added unit tests to check possible regressions (if your PR introduces new error messages, each of those should have a distinct test case) +* [ ] I did not introduce unrelated formatting/whitespace changes in the code base +* [ ] I did not do unrelated and/or undiscussed refactorings From 36c39ad5511769cc5ac4d676c2303b44a75a7815 Mon Sep 17 00:00:00 2001 From: Anton Trunov Date: Wed, 27 Mar 2024 22:34:18 +0300 Subject: [PATCH 2/4] Update .github/workflows/pull_request_template.md Co-authored-by: Novus Nota <68142933+novusnota@users.noreply.github.com> --- .github/workflows/pull_request_template.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pull_request_template.md b/.github/workflows/pull_request_template.md index 4f01f568b..d085b801a 100644 --- a/.github/workflows/pull_request_template.md +++ b/.github/workflows/pull_request_template.md @@ -1,4 +1,9 @@ -Closes issue #number +Closes #number + + * [ ] I have updated CHANGELOG.md * [ ] I have added unit tests to check possible regressions (if your PR introduces new error messages, each of those should have a distinct test case) From c7727af4ea9c7f802ed1f77a3fc1cd8d650a1e54 Mon Sep 17 00:00:00 2001 From: Anton Trunov Date: Wed, 27 Mar 2024 22:36:51 +0300 Subject: [PATCH 3/4] Update .github/workflows/pull_request_template.md --- .github/workflows/pull_request_template.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/pull_request_template.md b/.github/workflows/pull_request_template.md index d085b801a..4e9e6e640 100644 --- a/.github/workflows/pull_request_template.md +++ b/.github/workflows/pull_request_template.md @@ -7,5 +7,6 @@ If your PR doesn't close a particular issue, please, create the issue first and * [ ] I have updated CHANGELOG.md * [ ] I have added unit tests to check possible regressions (if your PR introduces new error messages, each of those should have a distinct test case) +* [ ] I have run all the tests locally and no test failure was reported * [ ] I did not introduce unrelated formatting/whitespace changes in the code base * [ ] I did not do unrelated and/or undiscussed refactorings From 09e959a2668c3e39705e97f295795dbd4566fd70 Mon Sep 17 00:00:00 2001 From: Anton Trunov Date: Wed, 27 Mar 2024 22:54:36 +0300 Subject: [PATCH 4/4] Update .github/workflows/pull_request_template.md --- .github/workflows/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull_request_template.md b/.github/workflows/pull_request_template.md index 4e9e6e640..8da74524c 100644 --- a/.github/workflows/pull_request_template.md +++ b/.github/workflows/pull_request_template.md @@ -6,7 +6,7 @@ If your PR doesn't close a particular issue, please, create the issue first and --> * [ ] I have updated CHANGELOG.md -* [ ] I have added unit tests to check possible regressions (if your PR introduces new error messages, each of those should have a distinct test case) +* [ ] I have added unit tests to demonstrate the contribution is correctly implemented * [ ] I have run all the tests locally and no test failure was reported * [ ] I did not introduce unrelated formatting/whitespace changes in the code base * [ ] I did not do unrelated and/or undiscussed refactorings