Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add a pull request template #202

Merged
merged 5 commits into from
Mar 27, 2024
Merged

chore: add a pull request template #202

merged 5 commits into from
Mar 27, 2024

Conversation

anton-trunov
Copy link
Member

@anton-trunov anton-trunov commented Mar 27, 2024 •
edited
Loading

Partially fixes #201 :)

  • I have updated CHANGELOG.md
  • I have added unit tests to check possible regressions (if your PR introduces new error messages, each of those should have a distinct test case)
  • I have run all the tests locally and no test failure was reported
  • I did not introduce unrelated formatting/whitespace changes in the code base
  • I did not do unrelated and/or undiscussed refactorings

@anton-trunov anton-trunov added this to the v1.3.0 milestone Mar 27, 2024
@anton-trunov anton-trunov self-assigned this Mar 27, 2024
@anton-trunov anton-trunov requested a review from novusnota March 27, 2024 18:56
anton-trunov and others added 2 commits March 27, 2024 22:34
@anton-trunov @novusnota
Update .github/workflows/pull_request_template.md
36c39ad 
Co-authored-by: Novus Nota <68142933+novusnota@users.noreply.github.com>
@anton-trunov
Merge branch 'main' into pr-template
2ec77eb
novusnota
novusnota previously approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@novusnota novusnota left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

  • «I solemnly swear that I am up to no good all the best!».

@byakuren-hijiri
Copy link
Contributor

(if your PR introduces new error messages, each of those should have a distinct test case)

Perhaps, we don't need to emphasize that part, as we expect that the contributor will cover everything with unit tests. Otherwise, we can mention this on code review.

@anton-trunov
Copy link
Member Author

Rephrased the part about unit tests

@anton-trunov anton-trunov requested a review from novusnota March 27, 2024 19:55
@anton-trunov anton-trunov merged commit 4c57124 into main Mar 27, 2024
3 checks passed
@anton-trunov anton-trunov deleted the pr-template branch March 27, 2024 20:02
@anton-trunov anton-trunov mentioned this pull request Mar 28, 2024
Merged
5 tasks
@verytactical verytactical added the scope: ci Continuous Integration: GitHub Actions (.github), commit/push hooks (.husky) label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byakuren-hijiri byakuren-hijiri byakuren-hijiri approved these changes

@novusnota novusnota novusnota approved these changes

@Gusarich Gusarich Awaiting requested review from Gusarich

Assignees

@anton-trunov anton-trunov

Labels
scope: ci Continuous Integration: GitHub Actions (.github), commit/push hooks (.husky)
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Add a pull request template
4 participants
@anton-trunov @byakuren-hijiri @novusnota @verytactical