Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add constants for reserve modes #173

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Add constants for reserve modes #173

merged 2 commits into from
Mar 25, 2024

Conversation

Gusarich
Copy link
Member

closes #172

@Gusarich Gusarich added this to the v1.3.0 milestone Mar 12, 2024
@Gusarich Gusarich requested a review from anton-trunov March 12, 2024 13:03
@Gusarich
Copy link
Member Author

Gusarich commented Mar 12, 2024 •
edited
Loading

@novusnota also would be nice to see a better explanation on these modes in docs, similarly to what we have for SendParamters

@novusnota
Copy link
Member

@Gusarich sure, right after version 1.3.0 gets released

anton-trunov
anton-trunov requested changes Mar 12, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, there are three base modes and three flags which are supposed to modify the base mode behavior. I'd like to have this distinction in the constant names too.

@anton-trunov anton-trunov self-assigned this Mar 15, 2024
@anton-trunov anton-trunov added scope: stdlib The Tact standard library (src/stdlib) enhancement labels Mar 15, 2024
anton-trunov
anton-trunov approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After an internal discussion, looks like we can merge this without making a distinction between base modes and flags changing their behavior

@anton-trunov anton-trunov merged commit e0a3288 into tact-lang:main Mar 25, 2024
3 checks passed
@anton-trunov anton-trunov mentioned this pull request Mar 25, 2024
Merged
@tonMaxi
Copy link

tonMaxi commented May 5, 2024

wowo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

Assignees

@anton-trunov anton-trunov

Labels
scope: stdlib The Tact standard library (src/stdlib)
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

stdlib: Introduce constants for modes of nativeReserve()
4 participants
@Gusarich @novusnota @tonMaxi @anton-trunov