Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merged random generation functions for tests into one file #1570

Merged
merged 2 commits into from
Jan 26, 2025
Merged

merged random generation functions for tests into one file #1570

merged 2 commits into from
Jan 26, 2025

Conversation

Danil42Russia
Copy link
Contributor

Continued from https://github.com/tact-lang/tact/pull/1568/files#r1929549119

  1. renamed the testKey function to randomKey;
  2. merged randomAddress and randomKey into one file random-utils.ts.

Checklist

  • I have updated CHANGELOG.md
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@Danil42Russia Danil42Russia requested a review from a team as a code owner January 25, 2025 16:55
anton-trunov
anton-trunov requested changes Jan 26, 2025
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo one imports fix

@anton-trunov anton-trunov self-assigned this Jan 26, 2025
@anton-trunov anton-trunov added the kind: refactoring Improve code readability label Jan 26, 2025
@anton-trunov anton-trunov added this to the v1.6.0 milestone Jan 26, 2025
@anton-trunov anton-trunov added the kind: testing Tests (*.spec.ts) label Jan 26, 2025
@anton-trunov anton-trunov merged commit 72e0f2c into tact-lang:main Jan 26, 2025
22 checks passed
@verytactical
Copy link
Contributor

Thank you!

@Danil42Russia Danil42Russia deleted the danil42russia/merged_random_function branch January 30, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

Assignees

@anton-trunov anton-trunov

Labels
kind: refactoring Improve code readability kind: testing Tests (*.spec.ts)
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Danil42Russia @verytactical @anton-trunov