-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove the crc-32
library from dependency
#1565
remove the crc-32
library from dependency
#1565
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original issue started specifically with
Write tests with a contract that uses crc32 function that pass strings with unicode characters.
Until there are tests for unicode characters, or rather any crc32 tests at all, we can't even know that hash is computed the way it did before, and can't do any of these changes.
Imagine worst-case scenario: we have something like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are looking for ways to make our code verifiable, so no tables like that should be hardcoded
Can you then create a issue to remove the table in |
Issue
Closes #1437.
The table was generated in advance, via:
If you need to write tests, I'll add them
Checklist