Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(traits): error on circular trait dependencies #1452

Merged
merged 3 commits into from
Jan 21, 2025
Merged

fix(traits): error on circular trait dependencies #1452

merged 3 commits into from
Jan 21, 2025

Conversation

i582
Copy link
Contributor

@i582 i582 commented Jan 21, 2025 •
edited by anton-trunov
Loading

This fixes issue 2 of Trail of Bits security audit (2024)

Original commit: d12cf94

Added additional test with deep inheritance.

Issue

Closes #1380.

Checklist

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@i582
fix: (backport) error on circular trait dependencies
55c77e9 
This fixes issue #2 of Trail of Bits security audit (2024)

Original commit: d12cf94

Fixes #1380
@i582 i582 added this to the v1.6.0 milestone Jan 21, 2025
@i582 i582 requested a review from a team as a code owner January 21, 2025 07:07
@anton-trunov anton-trunov changed the title fix: (backport) error on circular trait dependencies fix(traits): error on circular trait dependencies Jan 21, 2025
@anton-trunov anton-trunov self-assigned this Jan 21, 2025
anton-trunov
anton-trunov previously approved these changes Jan 21, 2025
View reviewed changes
@anton-trunov anton-trunov merged commit 727b4fe into main Jan 21, 2025
16 of 17 checks passed
@anton-trunov anton-trunov deleted the pmakhnev/backport/fix-trait-curcular-deps branch January 21, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

Stack overflow on circular trait dependencies
2 participants
@i582 @anton-trunov