Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): updated typescript-eslint #1425

Merged

Conversation

Danil42Russia
Copy link
Contributor

@Danil42Russia Danil42Russia commented Jan 20, 2025

Issue

Closes #1430.

There will likely be errors on CI that I couldn't catch locally, I'll fix them. Also maybe some of my solutions to errors are not suitable for you, I am ready to fix them.

Checklist

  • I have updated CHANGELOG.md
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@Danil42Russia Danil42Russia requested a review from a team as a code owner January 20, 2025 19:06
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's resolve the comments by @verytactical. (Doing this request to change the status of this PR to "Changes Requested")

@@ -134,8 +134,7 @@ export const ArgParser = (Errors: ArgParserErrors) => {
},
});

// eslint-disable-next-line @typescript-eslint/ban-types
const tokenizer = makeTokenizer<{}>((argv) => {
const tokenizer = makeTokenizer<object>((argv) => {
Copy link

@reverofevil reverofevil Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't change types here.

@anton-trunov anton-trunov merged commit f937337 into tact-lang:main Jan 29, 2025
22 checks passed
@anton-trunov anton-trunov added this to the v1.6.0 milestone Jan 29, 2025
@i582
Copy link
Contributor

i582 commented Jan 29, 2025

yt1s.com.-.mp4

@Danil42Russia Danil42Russia deleted the danil42russia/update_typescript_eslint branch January 30, 2025 10:49
sansx pushed a commit to TownSquareXYZ/tact that referenced this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update typescript-eslint
5 participants