Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): allow serialization specifiers for trait fields #1303

Merged

Conversation

i582
Copy link
Contributor

@i582 i582 commented Jan 13, 2025

Issue

Closes #655.

Checklist

  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@i582 i582 requested a review from a team as a code owner January 13, 2025 21:54
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add some diamond-like inheritance tests

src/types/resolveDescriptors.ts Outdated Show resolved Hide resolved
@anton-trunov anton-trunov self-assigned this Jan 14, 2025
@anton-trunov anton-trunov added this to the v1.6.0 milestone Jan 14, 2025
@i582 i582 requested a review from anton-trunov January 14, 2025 08:01
src/types/resolveDescriptors.ts Outdated Show resolved Hide resolved
@anton-trunov anton-trunov merged commit 2dcff76 into main Jan 14, 2025
18 checks passed
@anton-trunov anton-trunov deleted the pmakhnev/allow-serialization-specifiers-for-trait-fields branch January 14, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow serialization specifiers for trait variables
2 participants