-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types): forbid override
modifier for functions without super-function
#1302
fix(types): forbid override
modifier for functions without super-function
#1302
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After fixing some test file names, let's also add tests with inheriting a defined function through a sequence of traits and then overriding it, something along these lines:
trait T1 { fun foo() { } }
trait T2 with T1 { }
trait T3 with T2 { }
contract Test with T3 { override fun foo() { } }
src/types/test-failed/override-for-non-existing-function-in-trait-without-inheritance.tact
Outdated
Show resolved
Hide resolved
src/types/test-failed/override-for-non-existing-function-in-contract-from-base-trait.tact
Outdated
Show resolved
Hide resolved
src/types/test-failed/override-for-non-existing-function-in-contract-without-inheritance.tact
Outdated
Show resolved
Hide resolved
src/types/test-failed/override-for-non-existing-function-in-contract.tact
Outdated
Show resolved
Hide resolved
src/types/test/override-for-non-existing-function-in-trait-from-base-trait.tact
Outdated
Show resolved
Hide resolved
...test/override-for-non-existing-function-in-trait-with-multi-inheritance-from-base-trait.tact
Outdated
Show resolved
Hide resolved
src/types/test/override-for-non-existing-function-in-trait-with-multi-inheritance.tact
Outdated
Show resolved
Hide resolved
src/types/test/override-for-non-existing-function-in-trait-without-inheritance.tact
Outdated
Show resolved
Hide resolved
src/types/test/override-for-non-existing-function-in-trait.tact
Outdated
Show resolved
Hide resolved
Let's also add some diamond-like inheritance tests (if not added already) |
added |
override
modifier for functions without super-function
Issue
Closes #1022.
Checklist