Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(types): improve "The "remainder" field can only be the last field" inspection #1300

Merged
merged 3 commits into from
Jan 13, 2025
Merged

feat(types): improve "The "remainder" field can only be the last field" inspection #1300

merged 3 commits into from
Jan 13, 2025

Conversation

i582
Copy link
Contributor

@i582 i582 commented Jan 13, 2025 •
edited
Loading

Added declaration kind (struct or message) and location

Issue

Closes #1299.
See also #688.

Checklist

  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings
  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported

@i582
feat(types): improve "The "remainder" field can only be the last fiel…
676060f 
…d" inspection

Added declaration kind (struct or message) and location

Fix #1299
@i582 i582 requested a review from a team as a code owner January 13, 2025 19:00
anton-trunov
anton-trunov requested changes Jan 13, 2025
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit

CHANGELOG.md Outdated Show resolved Hide resolved
@anton-trunov anton-trunov self-assigned this Jan 13, 2025
@anton-trunov anton-trunov added this to the v1.6.0 milestone Jan 13, 2025
@anton-trunov anton-trunov merged commit 2bc9144 into main Jan 13, 2025
18 checks passed
@anton-trunov anton-trunov deleted the pmakhnev/remainder-field-in-struct-error-improvement branch January 13, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

'The "remainder" field can only be the last field' inspection may be more helpful
2 participants
@i582 @anton-trunov