Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support trailing commas for remaining comma-separated lists #245

Closed
novusnota opened this issue Apr 12, 2024 · 0 comments · Fixed by #246
Closed

Support trailing commas for remaining comma-separated lists #245

novusnota opened this issue Apr 12, 2024 · 0 comments · Fixed by #246
Assignees
@novusnota
Labels
scope: parser Implementation of parser (src/grammar)
Milestone
v1.3.0

Comments

@novusnota
Copy link
Member

novusnota commented Apr 12, 2024 •
edited
Loading

This is a follow-up to #179

grammar.ohm lacks support for trailing commas:

  • init() parameters
  • list of inherited traits (with ...)

Note, that as receive(), bounced() and external() have at most one parameter, it probably doesn't make sense to add trailing commas to them.
@anton-trunov anton-trunov added this to the v1.3.0 milestone Apr 12, 2024
@novusnota novusnota self-assigned this Apr 12, 2024
@novusnota novusnota mentioned this issue Apr 12, 2024
Merged
4 tasks
@verytactical verytactical added scope: parser Implementation of parser (src/grammar) and removed syntax labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@novusnota novusnota

Labels
scope: parser Implementation of parser (src/grammar)
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging a pull request may close this issue.

feat: Trailing commas for with ... lists and init() parameters novusnota-forks/tact
3 participants
@anton-trunov @novusnota @verytactical