Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contracts from this repo are being compiled with different result when building locally #100

Closed
Gusarich opened this issue Nov 29, 2023 · 3 comments · Fixed by #199
Closed

Contracts from this repo are being compiled with different result when building locally #100

Gusarich opened this issue Nov 29, 2023 · 3 comments · Fixed by #199
Assignees
@Gusarich
Milestone
v1.3.0

Comments

@Gusarich
Copy link
Member

Basically all smart contracts that are presented in this repo are producing builds that differs from those saved in the same repo. This makes contributing not very comfortable.

Screenshot 2023-11-29 at 8 04 39 PM

Steps to reproduce:

  1. Clone repo
  2. run yarn install
  3. run yarn gen or yarn test
@howardpen9
Copy link
Contributor

I think because the code in example folder in this repo is outdated.

@anton-trunov anton-trunov added this to the v1.3.0 milestone Feb 16, 2024
@anton-trunov
Copy link
Member

We could probably just add autogenerated things to .gitignore and stop committing those to the repo. I would guess nobody checks diffs between old and new auto-generated files because those are not really readable

@Gusarich Gusarich changed the title Contracts are being compiled with different result when building locally Contracts from this repo are being compiled with different result when building locally Mar 26, 2024
@Gusarich Gusarich self-assigned this Mar 27, 2024
@Gusarich Gusarich mentioned this issue Mar 27, 2024
Merged
@anton-trunov anton-trunov linked a pull request Mar 27, 2024 that will close this issue
Delete all autogenerated output folders and add them to gitignore #199
Merged
@anton-trunov
Copy link
Member

Fixed in PR #199

@anton-trunov anton-trunov mentioned this issue Apr 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gusarich Gusarich

Labels
None yet
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging a pull request may close this issue.

Delete all autogenerated output folders and add them to gitignore Gusarich/tact
3 participants
@anton-trunov @howardpen9 @Gusarich