Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White bar under current prompt line #3

Open
mogenson opened this issue Jan 24, 2019 · 4 comments
Open

White bar under current prompt line #3

mogenson opened this issue Jan 24, 2019 · 4 comments

Comments

@mogenson
Copy link

After loading the xontrib from the master branch of this repo I see a white bar underneath my current prompt line. There is also about a one second delay after I press any key, before it is displayed in the terminal.

prompt-vi-mode

Otherwise, this xontrib seems to be working correctly. Setting $RIGHT_PROMPT = '{vi_mode}' shows the current input mode.

Is this white bar the intended behavior? Why does it seem to slow down the shell so much.

@t184256
Copy link
Owner

t184256 commented Jan 24, 2019

Unfortunately, I've just left for a trip leaving most of my devices behind and I cannot address the issues you've reported until the next week.

I don't know what causes the appearance of the white bar, and it's definitely not the intended behavior, but the sluggishness is expected.

The implementation relies on reevaluating all the prompts on each keypress, which is as horrible as it sounds, and gets even worse when VCS queries get involved.

@mogenson
Copy link
Author

No worries, just thought I'd check.

@t184256
Copy link
Owner

t184256 commented Feb 2, 2019

I can replicate this.

For some reason, $UPDATE_PROMPT_ON_KEYPRESS = True causes the white line to appear.

@Granitosaurus
Copy link

What $SHELL_TYPE are you guys running?

I can't replicate this with:

$SHEEL_TYPE='ptk2'
# maybe bottom bar is affecting it?
$PTK_STYLE_OVERRIDES['bottom-toolbar'] = 'noreverse'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants