Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design updates to better match COSMIC #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jackpot51
Copy link
Member

image(1)
image(2)

@jackpot51 jackpot51 requested review from a team February 25, 2025 17:59
@jackpot51 jackpot51 self-assigned this Feb 25, 2025
@jacobgkau jacobgkau self-assigned this Feb 28, 2025
Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes the text a bit smaller, but it's still legible on both 1x and 2x scaled screens. It could be an accessibility concern.

lemp13 before/after:
1000020417
1000020416

addw2 before/after:
1000020407
1000020414

Open Sans does include ↑ and ↓ characters, so switching from that to the words Up and Down doesn't seem necessary. Despite Launch using the words, most keyboards include arrows. I don't think it's likely to result in any confusion, though.

I do want a sign-off from @system76/ux before we merge this. Better matching COSMIC means worse matching classic Pop!_OS, which is still what we currently ship as stable. (Not sure if this was intended to wait until closer to when COSMIC's ready.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants