-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/externalID #48
Merged
wideawakening
merged 19 commits into
sysdiglabs:master
from
nkraemer-sysdig:feature/external_id
Oct 8, 2021
Merged
Feature/externalID #48
wideawakening
merged 19 commits into
sysdiglabs:master
from
nkraemer-sysdig:feature/external_id
Oct 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aq17
commented
Oct 1, 2021
•
edited
Loading
edited
- Require valid externalID to impersonate service account
- Fix errors in creating benchmark task/ cloud account
…n creating benchmark task/ cloud account
This PR includes/ fixes the single benchmark task changes from this PR also #37 |
@aq17 we gave a look at this
now, besides these modifications, integration tests fail on
|
merged in #55 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.