Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/externalID #48

Merged
merged 19 commits into from
Oct 8, 2021

Conversation

aq17
Copy link

@aq17 aq17 commented Oct 1, 2021

  • Require valid externalID to impersonate service account
  • Fix errors in creating benchmark task/ cloud account

@aq17
Copy link
Author

aq17 commented Oct 5, 2021

This PR includes/ fixes the single benchmark task changes from this PR also #37

@hayk99 hayk99 mentioned this pull request Oct 7, 2021
@wideawakening
Copy link
Contributor

@aq17 we gave a look at this

  • pushed pre-merge check issue fixes, that are mandatory before merge
  • most of these checks can be pre-validated using the pre-commit plugin, which is explained in the /CONTRIBUTE.md (just uploaded it, is same for every terraform module we have for the moment).
  • as long as checks are OK you're good to merge

now, besides these modifications, integration tests fail on

@wideawakening
Copy link
Contributor

merged in #55

@wideawakening wideawakening merged commit 6b31b51 into sysdiglabs:master Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants