Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bugs and Add Features #32

Merged
merged 14 commits into from
Dec 17, 2024
Merged

Fix Bugs and Add Features #32

merged 14 commits into from
Dec 17, 2024

Conversation

adelhpour
Copy link
Member

Pull Request Note

This pull request includes the follwonig bug fixes and feature additions:

1. Bug Fixes:

  • Fixed the bug with user-set canvas dimensions vanishing after calling autolayout.
  • Resolved the bug where the color features of a group of graphical objects were not being set correctly. A test was added to ensure this fix is properly validated.
  • Addressed a bug with the 'getNumSpeciesReferenceAssociatedWithSpecies' function.

2. New Features:

  • Added an API function 'updateReactionCurves' to allow users to update curve features.
  • Introduced options to:
    • Disable/enable autolayout while loading.
    • Toggle stoichiometric species references on and off.

3. Tests:

  • Some tests were added or updated to verify the fixes and new features:
    • Tests were created for the bug fix related to graphical object color features.
    • New tests for the 'getNumSpeciesReferenceAssociatedWithSpecies' function were added.
    • Tests were also added to verify the new options for autolayout and species references.
    • A test was modified to check the bug fix related to user-set canvas dimensions vanishing after calling autolayout.

These changes improve stability and introduce helpful features for users working with graphical objects and species references.

adelhpour and others added 14 commits December 16, 2024 11:45
@adelhpour
- The bug with user-set canvas dimensions vanishing after calling aut…
f5b90cc 
…olayout fixed

- A test is modified to check for it
@adelhpour
- minor fix
e461c42
@adelhpour
the bug with 'getNumSpeciesReferenceAssociatedWithSpecies' function n…
e472b88 
…ot having 'layout_index' parameter on the Python api is fixed
@adelhpour
The test for 'getNumSpeciesReferenceAssociatedWithSpecies' function i…
fd2855d 
…s added
@adelhpour
- the option to set whether to disable the autolayout while loading o…
3d94841 
…r not is added

- the option to turn stoichiometric species references on and off is added

- tests are added for the newly added features
@adelhpour
fix the issue with the test syntax
8e9f818
@adelhpour
API function to give the user access to update curve feature is added…
829805d 
… ('updateReactionCurves')
@adelhpour
- Fix the bug with setting the color features of a group of graphica…
98ac731 
…l objects

- A test is added to check for this bug fix
@adelhpour
- Fix the issue with 'test_layout_size' test
5017b5e
@adelhpour
_ fix the issue with retrieving 'use_name_as_text_label' and 'stoichi…
6ffefba 
…ometric_species_reference' values
@adelhpour
minor syntax fix
4228ba3
@adelhpour
Merge branch 'develop' into add-features-fix-bugs
b3087cf
@adelhpour
minor syntax fix
690297d
@adelhpour
the check on the value of the 'useNameAsTextLabel' and 'Stoichiometri…
d4fbd21 
…cSpeciesReference' flags is removed from the tests
@adelhpour adelhpour merged commit c7b9c95 into develop Dec 17, 2024
8 of 10 checks passed
@adelhpour adelhpour deleted the add-features-fix-bugs branch December 17, 2024 21:36
@adelhpour adelhpour mentioned this pull request Dec 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adelhpour