-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security] CVE Patch #390
base: main
Are you sure you want to change the base?
[Security] CVE Patch #390
Conversation
To patch CVE
docker-compose.base.yml
Outdated
@@ -1,6 +1,6 @@ | |||
services: | |||
feed-requests-redis-cache: | |||
image: redis:7.0.7-alpine | |||
image: redis:7.4.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed alpine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yeah, let me add it
@@ -24,7 +24,7 @@ services: | |||
command: mongod --port 27017 | |||
logging: | |||
driver: none | |||
image: mongo:7.0.2 | |||
image: mongo:8.0.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be downgraded to the latest available version of v7 to keep this within the scope of patching? While I'm not opposed to major version upgrades, I believe it would be prudent to involve some more rigorous testing - something that I unfortunately lack the bandwidth for at the moment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch - I only have one request for changes
This is just patch to avoid known CVE issued by redis,mongo and postgres which mainly RCE.
Those version be tested over week on our production enviroment and not cause any harm with current implement in use.
=Ref=
redis
mongo
postgres
=Note=
RabbitMQ also better to get patched to newer but it would require some code edit which more likely going to take times so I left as it is this time.