Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async backups #194

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Async backups #194

merged 3 commits into from
Dec 4, 2023

Conversation

Jasonvdb
Copy link
Collaborator

Remote state persistence now happens in the background. This fixes crashes on iOS when moving app to background during persisting. Also should improve android performance.

  • iOS performs backups on 3 dispatch queues. One for channel manager, channel monitors and misc. This ensures each backup is done in the correct order without grouped older ones ever completing before a newer persist so server always has the latest state.
  • Android uses background threads, a backup queue and a locking mechanism to achieve the same thing.

@Jasonvdb Jasonvdb merged commit a300096 into master Dec 4, 2023
4 of 6 checks passed
@Jasonvdb Jasonvdb deleted the async-backups branch December 4, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coreyphillips coreyphillips coreyphillips approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jasonvdb @coreyphillips