Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump react-native-ldk #1947

Merged
merged 1 commit into from
Jun 5, 2024
Merged

chore: bump react-native-ldk #1947

merged 1 commit into from
Jun 5, 2024

Conversation

Jasonvdb
Copy link
Collaborator

@Jasonvdb Jasonvdb commented Jun 5, 2024

Description

Updates react-native-ldk to include:

Linked Issues/Tasks

#1882

Add any links to GitHub issues or Asana tasks that are relevant to this pull request.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

QA Notes

Hopefully see less dropped peer connections on android

@Jasonvdb Jasonvdb requested review from pwltr and ovitrif June 5, 2024 07:16
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/accepts@1.3.8 None +1 44.2 kB dougwilson
npm/acorn@8.11.3 None 0 531 kB marijn
npm/ansi-regex@5.0.1 None 0 5.61 kB qix
npm/async@3.2.4 None 0 821 kB hargasinski
npm/bn.js@4.12.0 None 0 95.7 kB fanatid
npm/brorand@1.1.0 None 0 3.52 kB indutny
npm/browserify-aes@1.2.0 None +1 34.6 kB cwmma
npm/buffer@5.7.1 None 0 82.5 kB feross
npm/decode-uri-component@0.2.2 None 0 6.09 kB samverschueren
npm/deepmerge@4.3.1 None 0 31.2 kB tehshrike
npm/diff-sequences@29.6.3 None 0 46 kB simenb
npm/domhandler@5.0.3 None +1 86.7 kB feedic
npm/entities@4.5.0 None 0 413 kB feedic
npm/error-stack-parser@2.1.4 None +1 59.5 kB titanism
npm/escape-html@1.0.3 None 0 3.66 kB dougwilson
npm/esprima@4.0.1 None 0 314 kB ariya
npm/event-target-shim@5.0.1 None 0 189 kB mysticatea
npm/evp_bytestokey@1.0.3 None +2 18.9 kB dcousens
npm/get-caller-file@2.0.5 None 0 4.72 kB stefanpenner
npm/hash.js@1.1.7 None 0 41.7 kB indutny
npm/is-date-object@1.0.5 None +1 31.7 kB ljharb
npm/is-docker@2.2.1 filesystem 0 3.01 kB sindresorhus
npm/is-symbol@1.0.4 None 0 22 kB ljharb
npm/is-wsl@2.2.0 environment, filesystem 0 3.76 kB sindresorhus
npm/isarray@1.0.0 None 0 3.89 kB juliangruber
npm/istanbul-lib-coverage@3.2.0 None 0 29.3 kB oss-bot
npm/jest-environment-node@29.7.0 unsafe +2 72.7 kB simenb
npm/jest-worker@29.7.0 environment, shell +3 108 kB simenb
npm/merge2@1.4.1 None 0 8.9 kB zensh
npm/mime-db@1.52.0 None 0 206 kB dougwilson
npm/mime-types@2.1.35 None 0 18.3 kB dougwilson
npm/minimalistic-assert@1.0.1 None 0 1.55 kB cwmma
npm/neo-async@2.6.2 None 0 298 kB suguru03
npm/node-gyp-build@4.6.0 environment, filesystem 0 13.1 kB mafintosh
npm/parse-asn1@5.1.6 None +1 26.8 kB cwmma
npm/picomatch@2.3.1 None 0 90 kB mrmlnc
npm/prompts@2.4.2 None +2 203 kB terkelg
npm/queue-microtask@1.2.3 None 0 8.37 kB feross
npm/safer-buffer@2.1.2 None 0 42.3 kB chalker
npm/serve-static@1.15.0 None +2 43.4 kB dougwilson
npm/set-function-name@2.0.1 None +2 36.2 kB ljharb
npm/source-map@0.6.1 None 0 805 kB tromey
npm/type-check@0.4.0 None +1 57.9 kB gkz
npm/unpipe@1.0.0 None 0 4.31 kB dougwilson
npm/util-deprecate@1.0.2 None 0 5.48 kB tootallnate
npm/v8-to-istanbul@9.1.0 filesystem, unsafe +1 60.8 kB oss-bot
npm/walker@1.0.8 filesystem 0 5.8 kB daaku
npm/which-typed-array@1.1.13 None +3 67.4 kB ljharb

🚮 Removed packages: npm/@babel/code-frame@7.24.2, npm/@babel/compat-data@7.24.1, npm/@babel/core@7.24.4, npm/@babel/generator@7.24.4, npm/@babel/helper-annotate-as-pure@7.18.6, npm/@babel/helper-compilation-targets@7.23.6, npm/@babel/helper-create-class-features-plugin@7.24.1, npm/@babel/helper-create-regexp-features-plugin@7.22.1, npm/@babel/helper-function-name@7.21.0, npm/@babel/helper-plugin-utils@7.21.5, npm/@babel/helper-string-parser@7.24.1, npm/@babel/helpers@7.24.4, npm/@babel/highlight@7.24.2, npm/@babel/parser@7.24.4, npm/@babel/plugin-syntax-export-default-from@7.18.6, npm/@babel/plugin-syntax-flow@7.21.4, npm/@babel/plugin-syntax-jsx@7.21.4, npm/@babel/plugin-syntax-typescript@7.21.4, npm/@babel/plugin-transform-async-to-generator@7.24.1, npm/@babel/plugin-transform-classes@7.24.1, npm/@babel/plugin-transform-flow-strip-types@7.21.0, npm/@babel/plugin-transform-function-name@7.24.1, npm/@babel/plugin-transform-named-capturing-groups-regex@7.22.5, npm/@babel/plugin-transform-private-methods@7.24.1, npm/@babel/plugin-transform-private-property-in-object@7.24.1, npm/@babel/plugin-transform-typescript@7.22.3, npm/@babel/preset-env@7.24.4, npm/@babel/runtime@7.24.4, npm/@babel/template@7.24.0, npm/@babel/traverse@7.24.1, npm/@babel/types@7.24.0, npm/@bitcoinerlab/secp256k1@1.0.5, npm/@commitlint/cli@19.2.2, npm/@commitlint/config-conventional@19.2.2, npm/@craftzdog/react-native-buffer@6.0.5, npm/@formatjs/intl-datetimeformat@6.12.3, npm/@formatjs/intl-getcanonicallocales@2.3.0, npm/@formatjs/intl-locale@3.4.5, npm/@formatjs/intl-numberformat@8.10.1, npm/@formatjs/intl-pluralrules@5.2.12, npm/@formatjs/intl-relativetimeformat@11.2.12, npm/@gorhom/bottom-sheet@4.6.1, npm/@jest/types@29.6.3, npm/@ptsecurity/commitlint-config@2.0.0, npm/@radar/lnrpc@0.11.1-beta.1, npm/@react-native-clipboard/clipboard@1.12.1, npm/@react-native-community/blur@4.4.0, npm/@react-native-community/netinfo@11.3.1, npm/@react-native/babel-preset@0.73.21, npm/@react-native/eslint-config@0.73.2, npm/@react-native/metro-config@0.73.5, npm/@react-native/typescript-config@0.73.1, npm/@react-navigation/native-stack@6.9.26, npm/@react-navigation/native@6.1.17, npm/@react-navigation/stack@6.3.29, npm/@reduxjs/toolkit@2.2.3, npm/@shopify/react-native-skia@1.2.1, npm/@synonymdev/blocktank-client@0.0.50, npm/@synonymdev/blocktank-lsp-http-client@1.1.2, npm/@synonymdev/feeds@2.1.1, npm/@synonymdev/ledger@0.0.5, npm/@synonymdev/react-native-ldk@0.0.140, npm/@synonymdev/react-native-lnurl@0.0.7, npm/@synonymdev/result@0.0.2, npm/@synonymdev/slashtags-keychain@1.0.0, npm/@synonymdev/slashtags-profile@1.0.2, npm/@synonymdev/slashtags-url@1.0.1, npm/@synonymdev/slashtags-widget-bitcoin-feed@1.0.0, npm/@synonymdev/slashtags-widget-facts-feed@1.1.0, npm/@synonymdev/slashtags-widget-news-feed@1.1.0, npm/@synonymdev/slashtags-widget-price-feed@1.1.0, npm/@synonymdev/web-relay@1.0.7, npm/@types/b4a@1.6.4, npm/@types/babel__traverse@7.20.0, npm/@types/bip21@2.0.3, npm/@types/mime@3.0.4, npm/@types/node@20.3.2, npm/@types/react-native-dotenv@0.2.2, npm/@types/react@18.2.78, npm/@types/redux-logger@3.0.13, npm/@types/styled-components-react-native@5.2.5, npm/@types/url-parse@1.4.11, npm/@typescript-eslint/utils@5.62.0, npm/ajv@8.12.0, npm/b4a@1.6.3, npm/babel-jest@29.7.0, npm/babel-plugin-polyfill-corejs2@0.4.10, npm/babel-plugin-transform-remove-console@6.9.4, npm/beignet@0.0.37, npm/bip21@2.0.3, npm/bip32@4.0.0, npm/bitcoin-address-validation@2.2.3, npm/bitcoin-json-rpc@1.3.3, npm/bitcoin-units@0.3.0, npm/bitcoinjs-lib@6.1.5, npm/bs58check@3.0.1, npm/caniuse-lite@1.0.30001600, npm/core-js-compat@3.33.2, npm/cross-fetch@3.1.8, npm/cross-spawn@7.0.3, npm/define-properties@1.2.0, npm/detox@20.20.2, npm/electron-to-chromium@1.4.719, npm/eslint-plugin-ft-flow@3.0.7, npm/eslint-scope@5.1.1, npm/eslint@8.57.0, npm/espree@9.6.1, npm/fastestsmallesttextencoderdecoder-encodeinto@1.0.22, npm/fetch-blob@3.2.0, npm/flow-parser@0.206.0, npm/fuzzysort@1.9.0, npm/get-intrinsic@1.2.2, npm/glob@7.2.3, npm/hoist-non-react-statics@3.3.2, npm/husky@9.0.11, npm/i18next-icu@2.3.0, npm/i18next@23.11.2, npm/immer@10.0.4, npm/intl-messageformat@10.5.11, npm/jdenticon@3.2.0, npm/jest-util@29.7.0, npm/lnurl@0.24.2, npm/lottie-react-native@6.7.2, npm/metro-config@0.80.7, npm/metro-runtime@0.80.7, npm/mime@3.0.0, npm/mkdirp@0.5.6, npm/multi-sort-stream@1.0.4, npm/nan@2.17.0, npm/nano-staged@0.8.0, npm/nanoid@3.3.6, npm/node-fetch@2.6.11, npm/onetime@5.1.2, npm/pirates@4.0.5, npm/pretty-format@29.5.0, npm/process@0.11.10, npm/prop-types@15.8.1, npm/random-access-web-storage@2.0.0, npm/react-i18next@14.1.0, npm/react-native-address-generator@0.3.3, npm/react-native-biometrics@3.0.1, npm/react-native-bundle-visualizer@3.1.3, npm/react-native-camera-kit@14.0.0-beta13, npm/react-native-device-info@10.13.1, npm/react-native-dotenv@3.4.11, npm/react-native-draggable-flatlist@4.0.1, npm/react-native-exit-app@2.0.0, npm/react-native-fetch-api@3.0.0, npm/react-native-fs@2.20.0, npm/react-native-gesture-handler@2.15.0, npm/react-native-haptic-feedback@2.2.0, npm/react-native-image-picker@7.1.2, npm/react-native-keyboard-accessory@0.1.16, npm/react-native-keychain@8.2.0, npm/react-native-localize@3.0.2, npm/react-native-mmkv@2.12.2, npm/react-native-modal@13.0.1, npm/react-native-permissions@3.10.1, npm/react-native-polyfill-globals@3.1.0, npm/react-native-qrcode-svg@6.3.0, npm/react-native-quick-actions@0.3.13, npm/react-native-quick-base64@2.1.1, npm/react-native-quick-crypto@0.6.1, npm/react-native-randombytes@3.6.1, npm/react-native-reanimated-carousel@3.5.1, npm/react-native-reanimated@3.8.1, npm/react-native-release-profiler@0.1.6, npm/react-native-restart@0.0.27, npm/react-native-safe-area-context@4.9.0, npm/react-native-screens@3.30.1, npm/react-native-share@10.2.0, npm/react-native-skia-stub@0.0.1, npm/react-native-svg-transformer@1.3.0, npm/react-native-svg@15.1.0, npm/react-native-tcp-socket@5.6.2, npm/react-native-toast-message@2.2.0, npm/react-native-zip-archive@6.1.0, npm/react-native@0.73.8, npm/react-redux@9.1.1, npm/reactotron-react-native@5.1.6, npm/reactotron-redux@3.1.9, npm/redux-logger@3.0.6, npm/redux-persist@6.0.0, npm/redux-thunk@3.1.0, npm/redux@5.0.1, npm/rn-android-keyboard-adjust@2.1.2, npm/rn-qr-generator@1.4.0, npm/sodium-react-native-direct@0.4.2, npm/sodium-universal@4.0.0, npm/stream-json@1.8.0, npm/strip-ansi@6.0.1, npm/styled-components@5.3.11, npm/tslib@2.5.0, npm/url-parse@1.5.10, npm/wif@2.0.6

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package Note
Install scripts npm/detox@20.20.2
  • Install script: postinstall
  • Source: node scripts/postinstall.js
Install scripts npm/sodium-react-native-direct@0.4.2
  • Install script: postinstall
  • Source: tar -xzf libsodium/build.tgz --directory ./libsodium

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/detox@20.20.2
  • @SocketSecurity ignore npm/sodium-react-native-direct@0.4.2

@Jasonvdb Jasonvdb merged commit aab5af3 into master Jun 5, 2024
5 of 6 checks passed
@Jasonvdb Jasonvdb deleted the ldk-bump branch June 5, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants