Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ v1beta3 + RUB selector in RSy + default excluded fields #78

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

damsien
Copy link
Collaborator

@damsien damsien commented Jan 16, 2025

This PR brings:

  • The new apiVersion v1beta3 which cleans up the deprecated custom types used by the CRDs.
  • A way to fine-grain the research of the RemoteUserBindings made by the interception webhook. The fine-grained research can be made by using label selector in the RemoteSyncer object (.spec.remoteUserBindingSelector). If no label selector is specified, then all the RemoteUserBindings of the namespace are retrieved.
  • A way to configure a default cluster wide excluded fields. ConfigMaps with the label syngit.io/cluster-default-excluded-fields: "true" in the syngit namespace will be used as the default excluded fields for any RemoteSyncer in the cluster
  • A small bug fix where the conditions of the RemoteSyncer were not correctly updated.
  • Add a way to launch only one test among all of the behavior tests make test-selected TEST_NUMBER=X (01, 02, ...). It is launched in "fast" mode (same behavior as the fast-behavior command).

Signed-off-by: Damien Dassieu <dassieu.damien@gmail.com>
Signed-off-by: Damien Dassieu <dassieu.damien@gmail.com>
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 51.59420% with 501 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/api/v1beta3/zz_generated.deepcopy.go 43.64% 219 Missing and 16 partials ⚠️
pkg/api/v1beta3/remoteuser_conversion.go 0.00% 51 Missing ⚠️
internal/webhook/v1beta3/remotesyncer_webhook.go 41.09% 32 Missing and 11 partials ⚠️
pkg/api/v1beta3/remotesyncer_conversion.go 0.00% 42 Missing ⚠️
.../webhook/v1beta3/remoteuser_association_webhook.go 79.51% 23 Missing and 11 partials ⚠️
internal/interceptor/webhook_request_checker.go 65.71% 18 Missing and 6 partials ⚠️
.../webhook/v1beta3/remotesyncer_rules_permissions.go 70.51% 18 Missing and 5 partials ⚠️
pkg/api/v1beta3/remoteuserbinding_conversion.go 0.00% 20 Missing ⚠️
internal/webhook/v1beta3/remoteuser_webhook.go 50.00% 12 Missing and 2 partials ⚠️
.../webhook/v1beta3/remoteuser_secrets_permissions.go 74.28% 6 Missing and 3 partials ⚠️
... and 1 more
Files with missing lines Coverage Δ
internal/controller/remotesyncer_controller.go 77.92% <ø> (ø)
internal/controller/remoteuser_controller.go 73.45% <ø> (ø)
...nternal/controller/remoteuserbinding_controller.go 91.50% <100.00%> (+2.83%) ⬆️
internal/interceptor/dynamic_webhook_handlers.go 71.13% <100.00%> (+0.30%) ⬆️
internal/interceptor/git_pusher.go 67.83% <ø> (ø)
...ernal/webhook/v1beta3/remoteuserbinding_webhook.go 100.00% <100.00%> (ø)
pkg/api/v1beta3/remotesyncer_types.go 100.00% <100.00%> (ø)
pkg/api/v1beta3/remoteuser_types.go 100.00% <100.00%> (ø)
pkg/api/v1beta3/remoteuserbinding_types.go 100.00% <100.00%> (ø)
...l/webhook/v1beta3/remoteuserbinding_permissions.go 83.78% <83.78%> (ø)
... and 10 more

... and 14 files with indirect coverage changes

@damsien damsien force-pushed the main branch 3 times, most recently from 8076a1e to d255c5f Compare January 16, 2025 22:13
Signed-off-by: Damien Dassieu <dassieu.damien@gmail.com>
@damsien damsien merged commit d8efc01 into syngit-org:main Jan 16, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant