Bring support UI inline with design from UXD #1444
Conversation
| background-color: white; | ||
| padding: 2em; | ||
| } | ||
| @import 'patternfly-sass/assets/stylesheets/patternfly/variables'; |
There was a problem hiding this comment.
If we feel we'll want to refer to this SASS partial often, then let's add it to scss/base/_vendor.scss and then import syndesis-sass instead. This way we will not have to import the same partial again and again in the future
| font-size: $font-size-base; | ||
| padding-top: 5px; | ||
| } | ||
| } |
There was a problem hiding this comment.
Please add a EOF break here, thx :)
| <ng-template #viewTemplate> | ||
| <div class="toolbar-pf-action-right"> | ||
| <div class="form-group"> | ||
| <strong>{{ selectedItems() }}</strong> of <strong>{{ totalItems() }}</strong> Items |
There was a problem hiding this comment.
Two notes here, mostly addressed to @paoloantinori I guess:
Contrary to web docs rendered serverside, SPA documents are not evaluated upon rendering on screen for the first time but often through a change detection loop, which spawns a new cycle every few (very few) milliseconds. This means that whatever function call we drop in our views will be executed every few milliseconds too. And here we can see there're two function calls. While totalItems() just returns a class field length value, which is just fine, selectedItems(), on the contrary, performs a lambda call. That can become memory expensive in the long run, so my suggestions would be to have just a selectedItems: number field defined at the SupportComponent class and update it every time the selected property changes by means of the click handler, whatever it is.
There was a problem hiding this comment.
In any event, we can get away with these bindings as is, since they only affect this component, which is meant to be eventually destroyed. However, please take into consideration the principles exposed above for the future, thanks. :)
fi(ui): Update yarn.lock, changed after removal of the guider tour
…ly/variables into _vendors.scss
…into support-ui
…ly/variables into _vendors.scss
…into support-ui
|
Please reapprove after the yarn lint errors are fixed. thanks ... |
|
@michael-coker this can't be merged until this run |
|
@gashcrumb done |
Updates to /support to bring more inline with design from UXD with some deviations from the design signed off on by the UXD team.
https://raw.githubusercontent.com/syndesisio/syndesis/master/ux/designs/support-page/img/supportpage-landing.png