bug #54854 [Stopwatch] undefined key error when trying to fetch a mis…

…sing section
symfony · Dec 18, 2024 · e46690d · e46690d
1 parent 696f418
commit e46690d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/Stopwatch.php b/Stopwatch.php
@@ -140,7 +140,7 @@ public function getEvent(string $name): StopwatchEvent
      */
     public function getSectionEvents(string $id): array
     {
-        return $this->sections[$id]->getEvents() ?? [];
+        return isset($this->sections[$id]) ? $this->sections[$id]->getEvents() : [];
     }
 
     /**

diff --git a/Tests/StopwatchTest.php b/Tests/StopwatchTest.php
@@ -187,4 +187,9 @@ public function testReset()
 
         $this->assertEquals(new Stopwatch(), $stopwatch);
     }
+
+    public function testShouldReturnEmptyArrayWhenSectionMissing()
+    {
+        $this->assertSame([], (new Stopwatch())->getSectionEvents('missing'));
+    }
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -140,7 +140,7 @@ public function getEvent(string $name): StopwatchEvent @@
          */
         public function getSectionEvents(string $id): array
         {
-            return $this->sections[$id]->getEvents() ?? [];
+            return isset($this->sections[$id]) ? $this->sections[$id]->getEvents() : [];
         }
         /**
@@ Expand Down @@