Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Traits] Integrate 'disallow disabling default traits of a package without traits' into resolution phase #8356

Open
1 task done
bripeticca opened this issue Mar 11, 2025 · 0 comments
Assignees
Labels

Comments

@bripeticca
Copy link
Contributor

Is it reproducible with SwiftPM command-line tools: swift build, swift test, swift package etc?

  • Confirmed reproduction steps with SwiftPM CLI. The description text must include reproduction steps with either of command-line SwiftPM commands, swift build, swift test, swift package etc.

Description

The PR #8326 has been successfully implemented in the modules graph loading phase, where traits were initially supported. Now that #8205 has been merged, this feature should be considered earlier on in resolution.

Expected behavior

The check for disallowing disabling default traits for a package without traits should be checked during resolution to omit any further calculations/checkouts/etc. if this condition fails.

Actual behavior

This check is being done after resolution has already completed.

Steps to reproduce

No response

Swift Package Manager version/commit hash

No response

Swift & OS version (output of swift --version ; uname -a)

No response

@bripeticca bripeticca added the bug label Mar 11, 2025
@bripeticca bripeticca self-assigned this Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant