Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Add missing source file to CMake #791

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

egorzhdan
Copy link

SubstringSearcher.swift wasn't in the list of source files for CMake target _StringProcessing, which caused a compilation error for me locally while building the Swift compiler.

`SubstringSearcher.swift` wasn't in the list of source files for CMake target _StringProcessing, which caused a compilation error for me locally while building the Swift compiler.
@egorzhdan
Copy link
Author

@swift-ci please test

@milseman
Copy link
Member

@natecook1000 any idea how this was building without this change?

@egorzhdan
Copy link
Author

Perhaps this isn't normally built with CMake, and that is why we haven't seen the failure before?

@milseman @natecook1000 do you think we could land this change?

@natecook1000
Copy link
Member

Did some looking into this, and the answer has two parts: (1) we don't normally build this project with CMake and don't have tests for doing that, and (2) when this project is included in the Swift project build, it doesn't use the CMake machinery here at all. Instead, it has its own CMakeLists where it just grabs all the Swift files: https://github.com/swiftlang/swift/blob/main/stdlib/public/StringProcessing/CMakeLists.txt#L30-L39

As such, I'm going to recommend we actually just remove the CMake machinery here instead of fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants