Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public inits, mutable properties and full Codable support #89

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Public inits, mutable properties and full Codable support #89

wants to merge 3 commits into from

Conversation

dscreve
Copy link

@dscreve dscreve commented Jan 28, 2025

Public inits, mutable properties and full Codable support

0xTim
0xTim requested changes Jan 28, 2025
View reviewed changes
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits

I'm still a little reluctant to open these types up but understand the desire and will likely out voted on this 😅

Sources/WebAuthn/Helpers/ChallengeGenerator.swift Outdated Show resolved Hide resolved
Sources/WebAuthn/WebAuthnManager.swift Outdated Show resolved Hide resolved
Sources/WebAuthn/Helpers/KeyedDecodingContainer+decodeURLEncoded.swift Outdated Show resolved Hide resolved
Sources/WebAuthn/Ceremonies/Registration/PublicKeyCredentialCreationOptions.swift Outdated Show resolved Hide resolved
0xTim
0xTim requested changes Feb 2, 2025
View reviewed changes
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit and a comment that's probably fine about a public type

Sources/WebAuthn/Ceremonies/Registration/PublicKeyCredentialCreationOptions.swift Outdated Show resolved Hide resolved
Sources/WebAuthn/Ceremonies/Registration/PublicKeyCredentialCreationOptions.swift Outdated Show resolved Hide resolved
Sources/WebAuthn/Helpers/KeyedDecodingContainer+decodeURLEncoded.swift Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitribouniol dimitribouniol dimitribouniol left review comments

@0xTim 0xTim 0xTim requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dscreve @dimitribouniol @0xTim