Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/51 dot last char #60

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Issue/51 dot last char #60

merged 3 commits into from
Jan 28, 2025

Conversation

Michiel-s
Copy link

This PR addresses the comment made by @zozlak in #57. Related to #51

The ending dot should not throw an error but be returned to the input buffer instead.

I've updated the QName parsing accordingly

@Michiel-s
Copy link
Author

@k00ni, @zozlak, looking forward to your review.

@k00ni k00ni added fix parser Parser related, most likely parsing failed labels Jan 23, 2025
@k00ni
Copy link
Member

k00ni commented Jan 28, 2025

Thank you both for investing the time.

@k00ni k00ni merged commit f42130d into sweetrdf:master Jan 28, 2025
11 checks passed
@Michiel-s Michiel-s deleted the issue/51-dot-last-char branch January 28, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix parser Parser related, most likely parsing failed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Michiel-s @k00ni