Issue/51 dot in name #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@k00ni would you be so kind to review this PR? Please let me know if changes are needed. |
|
Thanks for your contributions, I am super busy these days but I will try to get back to you until end of this week. |
|
Thank you. |
|
Don't want to be a party killer but if I am correct this implementation requires a blank between the pname and the dot ending a triple. The ending dot should not throw an error but be returned to the input buffer instead. |
I think you are right. Will check and create a pull request. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow dot in the middle of a QName.
Fixes #51
Added tests to check for allowed usage of dot in middle of name and a test to prevent the dot as last character of a name.